Unverified Commit d7a79616 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Mark Brown
Browse files

ASoC: codecs: rt712-sdca-dmic: do not store status in state container 



Driver in its update status callback stores Soundwire device status in
state container but it never uses it later.  Simplify the code a bit.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20230518072753.7361-9-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 22e15c18

sound/soc/codecs/rt712-sdca-dmic.c

+1 −4
Original line number Diff line number Diff line
@@ -803,9 +803,6 @@ static int rt712_sdca_dmic_update_status(struct sdw_slave *slave, 
{

	struct rt712_sdca_dmic_priv *rt712 = dev_get_drvdata(&slave->dev);



	/* Update the status */

	rt712->status = status;



	if (status == SDW_SLAVE_UNATTACHED)

		rt712->hw_init = false;
@@ -813,7 +810,7 @@ static int rt712_sdca_dmic_update_status(struct sdw_slave *slave, 
	 * Perform initialization only if slave status is present and

	 * hw_init flag is false

	 */

	if (rt712->hw_init || rt712->status != SDW_SLAVE_ATTACHED)

	if (rt712->hw_init || status != SDW_SLAVE_ATTACHED)

		return 0;



	/* perform I/O transfers required for Slave initialization */

sound/soc/codecs/rt712-sdca-dmic.h

+0 −1
Original line number Diff line number Diff line
@@ -16,7 +16,6 @@ struct rt712_sdca_dmic_priv { 
	struct regmap *mbq_regmap;

	struct snd_soc_component *component;

	struct sdw_slave *slave;

	enum sdw_slave_status status;

	struct sdw_bus_params params;

	bool hw_init;

	bool first_hw_init;