Commit d7900dae authored by Chuck Lever's avatar Chuck Lever
Browse files

SUNRPC: Improve observability in svc_tcp_accept() 



The -ENOMEM arm could fire repeatedly if the system runs low on
memory, so remove it.

Don't bother to trace -EAGAIN error events, since those fire after
a listener is created (with no work done) and once again after an
accept has been handled successfully (again, with no work done).

Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
parent cce4ee9c

net/sunrpc/svcsock.c

+2 −7
Original line number Diff line number Diff line
@@ -886,12 +886,7 @@ static struct svc_xprt *svc_tcp_accept(struct svc_xprt *xprt) 
	clear_bit(XPT_CONN, &svsk->sk_xprt.xpt_flags);

	err = kernel_accept(sock, &newsock, O_NONBLOCK);

	if (err < 0) {

		if (err == -ENOMEM)

			printk(KERN_WARNING "%s: no more sockets!\n",

			       serv->sv_name);

		else if (err != -EAGAIN)

			net_warn_ratelimited("%s: accept failed (err %d)!\n",

					     serv->sv_name, -err);

		if (err != -EAGAIN)

			trace_svcsock_accept_err(xprt, serv->sv_name, err);

		return NULL;

	}