Commit d78c8e32 authored by Anders Roxell's avatar Anders Roxell Committed by Michael Ellerman
Browse files

powerpc/mm: Rearrange if-else block to avoid clang warning 



Clang warns:

  arch/powerpc/mm/book3s64/radix_tlb.c:1191:23: error: variable 'hstart' is uninitialized when used here
    __tlbiel_va_range(hstart, hend, pid,
                      ^~~~~~
  arch/powerpc/mm/book3s64/radix_tlb.c:1191:31: error: variable 'hend' is uninitialized when used here
    __tlbiel_va_range(hstart, hend, pid,
                              ^~~~

Rework the 'if (IS_ENABLE(CONFIG_TRANSPARENT_HUGEPAGE))' so hstart/hend
is always initialized to silence the warnings. That will also simplify
the 'else' path. Clang is getting confused with these warnings, but the
warnings is a false-positive.

Suggested-by: default avatarArnd Bergmann <arnd@arndb.de>
Suggested-by: default avatarNathan Chancellor <nathan@kernel.org>
Reviewed-by: default avatarChristophe Leroy <christophe.leroy@csgroup.eu>
Reviewed-by: default avatarNathan Chancellor <nathan@kernel.org>
Signed-off-by: default avatarAnders Roxell <anders.roxell@linaro.org>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220810114318.3220630-1-anders.roxell@linaro.org
parent a7caf3f1

arch/powerpc/mm/book3s64/radix_tlb.c

+4 −7
Original line number Diff line number Diff line
@@ -1184,15 +1184,12 @@ static inline void __radix__flush_tlb_range(struct mm_struct *mm, 
			}

		}

	} else {

		bool hflush = false;

		bool hflush;

		unsigned long hstart, hend;



		if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) {

		hstart = (start + PMD_SIZE - 1) & PMD_MASK;

		hend = end & PMD_MASK;

			if (hstart < hend)

				hflush = true;

		}

		hflush = IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) && hstart < hend;



		if (type == FLUSH_TYPE_LOCAL) {

			asm volatile("ptesync": : :"memory");