Commit d78be404 authored Sep 27, 2022 by Yang Yingliang Committed by Viresh Kumar Oct 18, 2022

cpufreq: qcom-nvmem: Switch to use dev_err_probe() helper



In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

parent ab4fdc73

drivers/cpufreq/qcom-cpufreq-nvmem.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -299,11 +299,8 @@ static int qcom_cpufreq_probe(struct platform_device *pdev)
		if (drv->data->get_version) {
		speedbin_nvmem = of_nvmem_cell_get(np, NULL);
		if (IS_ERR(speedbin_nvmem)) {
		if (PTR_ERR(speedbin_nvmem) != -EPROBE_DEFER)
		dev_err(cpu_dev,
		"Could not get nvmem cell: %ld\n",
		PTR_ERR(speedbin_nvmem));
		ret = PTR_ERR(speedbin_nvmem);
		ret = dev_err_probe(cpu_dev, PTR_ERR(speedbin_nvmem),
		"Could not get nvmem cell\n");
		goto free_drv;
		}