Commit d768e504 authored by Bernard Zhao's avatar Bernard Zhao Committed by Rob Clark
Browse files

drm/msm/adreno: remove return value of function XX_print 



XX_print like pfp_print/me_print/meq_print/roq_print are just
used in file a5xx_debugfs.c. And these function always return
0, this return value is meaningless.
This change is to make the code a bit more readable.

Signed-off-by: default avatarBernard Zhao <bernard@vivo.com>
Reviewed-by: default avatarJordan Crouse <jcrouse@codeaurora.org>
Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
parent e1bf29e0

drivers/gpu/drm/msm/adreno/a5xx_debugfs.c

+7 −14
Original line number Diff line number Diff line
@@ -11,7 +11,7 @@ 


#include "a5xx_gpu.h"



static int pfp_print(struct msm_gpu *gpu, struct drm_printer *p)

static void pfp_print(struct msm_gpu *gpu, struct drm_printer *p)

{

	int i;
@@ -22,11 +22,9 @@ static int pfp_print(struct msm_gpu *gpu, struct drm_printer *p) 
		drm_printf(p, "  %02x: %08x\n", i,

			gpu_read(gpu, REG_A5XX_CP_PFP_STAT_DATA));

	}



	return 0;

}



static int me_print(struct msm_gpu *gpu, struct drm_printer *p)

static void me_print(struct msm_gpu *gpu, struct drm_printer *p)

{

	int i;
@@ -37,11 +35,9 @@ static int me_print(struct msm_gpu *gpu, struct drm_printer *p) 
		drm_printf(p, "  %02x: %08x\n", i,

			gpu_read(gpu, REG_A5XX_CP_ME_STAT_DATA));

	}



	return 0;

}



static int meq_print(struct msm_gpu *gpu, struct drm_printer *p)

static void meq_print(struct msm_gpu *gpu, struct drm_printer *p)

{

	int i;
@@ -52,11 +48,9 @@ static int meq_print(struct msm_gpu *gpu, struct drm_printer *p) 
		drm_printf(p, "  %02x: %08x\n", i,

			gpu_read(gpu, REG_A5XX_CP_MEQ_DBG_DATA));

	}



	return 0;

}



static int roq_print(struct msm_gpu *gpu, struct drm_printer *p)

static void roq_print(struct msm_gpu *gpu, struct drm_printer *p)

{

	int i;
@@ -71,8 +65,6 @@ static int roq_print(struct msm_gpu *gpu, struct drm_printer *p) 
		drm_printf(p, "  %02x: %08x %08x %08x %08x\n", i,

			val[0], val[1], val[2], val[3]);

	}



	return 0;

}



static int show(struct seq_file *m, void *arg)
@@ -81,10 +73,11 @@ static int show(struct seq_file *m, void *arg) 
	struct drm_device *dev = node->minor->dev;

	struct msm_drm_private *priv = dev->dev_private;

	struct drm_printer p = drm_seq_file_printer(m);

	int (*show)(struct msm_gpu *gpu, struct drm_printer *p) =

	void (*show)(struct msm_gpu *gpu, struct drm_printer *p) =

		node->info_ent->data;



	return show(priv->gpu, &p);

	show(priv->gpu, &p);

	return 0;

}



#define ENT(n) { .name = #n, .show = show, .data = n ##_print }