Commit d7499634 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Rob Clark
Browse files

drm/msm/adreno: Do not propagate void return values 



With sparse ("make C=2"), lots of

  error: return expression in void function

messages are seen.

Fix this by removing the return statements to propagate void return
values.

Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Patchwork: https://patchwork.freedesktop.org/patch/492529/
Link: https://lore.kernel.org/r/0083bc7e23753c19902580b902582ae499b44dbf.1657113388.git.geert@linux-m68k.org


Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
parent 18514c38

drivers/gpu/drm/msm/adreno/a6xx_gmu.c

+1 −1
Original line number Diff line number Diff line
@@ -505,7 +505,7 @@ static void a6xx_rpmh_stop(struct a6xx_gmu *gmu) 


static inline void pdc_write(void __iomem *ptr, u32 offset, u32 value)

{

	return msm_writel(value, ptr + (offset << 2));

	msm_writel(value, ptr + (offset << 2));

}



static void __iomem *a6xx_gmu_get_mmio(struct platform_device *pdev,

drivers/gpu/drm/msm/adreno/a6xx_gmu.h

+2 −2
Original line number Diff line number Diff line
@@ -98,7 +98,7 @@ static inline u32 gmu_read(struct a6xx_gmu *gmu, u32 offset) 


static inline void gmu_write(struct a6xx_gmu *gmu, u32 offset, u32 value)

{

	return msm_writel(value, gmu->mmio + (offset << 2));

	msm_writel(value, gmu->mmio + (offset << 2));

}



static inline void
@@ -138,7 +138,7 @@ static inline u32 gmu_read_rscc(struct a6xx_gmu *gmu, u32 offset) 


static inline void gmu_write_rscc(struct a6xx_gmu *gmu, u32 offset, u32 value)

{

	return msm_writel(value, gmu->rscc + (offset << 2));

	msm_writel(value, gmu->rscc + (offset << 2));

}



#define gmu_poll_timeout_rscc(gmu, addr, val, cond, interval, timeout) \

drivers/gpu/drm/msm/adreno/a6xx_gpu.c

+1 −1
Original line number Diff line number Diff line
@@ -1514,7 +1514,7 @@ static void a6xx_llc_rmw(struct a6xx_gpu *a6xx_gpu, u32 reg, u32 mask, u32 or) 


static void a6xx_llc_write(struct a6xx_gpu *a6xx_gpu, u32 reg, u32 value)

{

	return msm_writel(value, a6xx_gpu->llc_mmio + (reg << 2));

	msm_writel(value, a6xx_gpu->llc_mmio + (reg << 2));

}



static void a6xx_llc_deactivate(struct a6xx_gpu *a6xx_gpu)