Commit d72f78db authored by Peng Li's avatar Peng Li Committed by David S. Miller
Browse files

net: pc300too: move out assignment in if condition 



Should not use assignment in if condition.

Signed-off-by: default avatarPeng Li <lipeng321@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f8864e26

drivers/net/wan/pc300too.c

+4 −2
Original line number Diff line number Diff line
@@ -349,12 +349,14 @@ static int pc300_pci_init_one(struct pci_dev *pdev, 
	else

		card->n_ports = 2;



	for (i = 0; i < card->n_ports; i++)

		if (!(card->ports[i].netdev = alloc_hdlcdev(&card->ports[i]))) {

	for (i = 0; i < card->n_ports; i++) {

		card->ports[i].netdev = alloc_hdlcdev(&card->ports[i]);

		if (!card->ports[i].netdev) {

			pr_err("unable to allocate memory\n");

			pc300_pci_remove_one(pdev);

			return -ENOMEM;

		}

	}



	/* Reset PLX */

	p = &card->plxbase->init_ctrl;