Commit d6e51503 authored by Julian Wiedmann's avatar Julian Wiedmann Committed by Jakub Kicinski
Browse files

s390/qeth: don't fake a TX completion interrupt after TX error 



When do_qdio() returns with an unexpected error, qeth_flush_buffers()
kicks off a recovery action.

In such a case there's no point in starting TX completion processing,
the device gets torn down anyway. So take a closer look at do_qdio()'s
return value, and skip the TX completion processing accordingly.

Signed-off-by: default avatarJulian Wiedmann <jwi@linux.ibm.com>
Acked-by: default avatarWillem de Bruijn <willemb@google.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a667fee1

drivers/s390/net/qeth_core_main.c

+18 −16
Original line number Diff line number Diff line
@@ -3692,6 +3692,11 @@ static void qeth_flush_buffers(struct qeth_qdio_out_q *queue, int index, 
	rc = do_QDIO(CARD_DDEV(queue->card), qdio_flags,

		     queue->queue_no, index, count);



	switch (rc) {

	case 0:

	case -ENOBUFS:

		/* ignore temporary SIGA errors without busy condition */



		/* Fake the TX completion interrupt: */

		if (IS_IQD(card)) {

			unsigned int frames = READ_ONCE(queue->max_coalesced_frames);
@@ -3706,10 +3711,8 @@ static void qeth_flush_buffers(struct qeth_qdio_out_q *queue, int index, 
			}

		}



	if (rc) {

		/* ignore temporary SIGA errors without busy condition */

		if (rc == -ENOBUFS)

			return;

		break;

	default:

		QETH_CARD_TEXT(queue->card, 2, "flushbuf");

		QETH_CARD_TEXT_(queue->card, 2, " q%d", queue->queue_no);

		QETH_CARD_TEXT_(queue->card, 2, " idx%d", index);
@@ -3719,7 +3722,6 @@ static void qeth_flush_buffers(struct qeth_qdio_out_q *queue, int index, 
		/* this must not happen under normal circumstances. if it

		 * happens something is really wrong -> recover */

		qeth_schedule_recovery(queue->card);

		return;

	}

}