Commit d6e4fd52 authored by Miquel Raynal's avatar Miquel Raynal
Browse files

mtd: rawnand: nandsim: Stop using nand_release() 



nand_release() basically calls mtd_device_unregister() and
nand_cleanup(). Both helpers should be called after MTD device
registration and NAND scan, respectively. Drop nand_release() and use
the two helpers directly so that they fit the error path and the
labels there.

Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200525085851.17682-12-miquel.raynal@bootlin.com
parent 72e840a1

drivers/mtd/nand/raw/nandsim.c

+4 −2
Original line number Diff line number Diff line
@@ -2400,13 +2400,15 @@ static int __init ns_init_module(void) 


	ret = ns_debugfs_create(ns);

	if (ret)

		goto err_exit;

		goto unregister_mtd;



        return 0;



unregister_mtd:

	WARN_ON(mtd_device_unregister(nsmtd));

err_exit:

	ns_free(ns);

	nand_release(chip);

	nand_cleanup(chip);

error:

	kfree(ns);

	ns_free_lists();