Commit d6c5dc18 authored by Joe Perches's avatar Joe Perches Committed by Corey Minyard
Browse files

ipmi: Remove uses of return value of seq_printf 



The seq_printf like functions will soon be changed to return void.

Convert these uses to check seq_has_overflowed instead.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
parent 2d06a0c9

drivers/char/ipmi/ipmi_msghandler.c

+8 −4
Original line number Diff line number Diff line
@@ -1998,7 +1998,9 @@ static int smi_ipmb_proc_show(struct seq_file *m, void *v) 
	seq_printf(m, "%x", intf->channels[0].address);

	for (i = 1; i < IPMI_MAX_CHANNELS; i++)

		seq_printf(m, " %x", intf->channels[i].address);

	return seq_putc(m, '\n');

	seq_putc(m, '\n');



	return seq_has_overflowed(m);

}



static int smi_ipmb_proc_open(struct inode *inode, struct file *file)
@@ -2017,9 +2019,11 @@ static int smi_version_proc_show(struct seq_file *m, void *v) 
{

	ipmi_smi_t intf = m->private;



	return seq_printf(m, "%u.%u\n",

	seq_printf(m, "%u.%u\n",

		   ipmi_version_major(&intf->bmc->id),

		   ipmi_version_minor(&intf->bmc->id));



	return seq_has_overflowed(m);

}



static int smi_version_proc_open(struct inode *inode, struct file *file)

drivers/char/ipmi/ipmi_si_intf.c

+15 −11
Original line number Diff line number Diff line
@@ -2979,7 +2979,9 @@ static int smi_type_proc_show(struct seq_file *m, void *v) 
{

	struct smi_info *smi = m->private;



	return seq_printf(m, "%s\n", si_to_str[smi->si_type]);

	seq_printf(m, "%s\n", si_to_str[smi->si_type]);



	return seq_has_overflowed(m);

}



static int smi_type_proc_open(struct inode *inode, struct file *file)
@@ -3041,7 +3043,7 @@ static int smi_params_proc_show(struct seq_file *m, void *v) 
{

	struct smi_info *smi = m->private;



	return seq_printf(m,

	seq_printf(m,

		   "%s,%s,0x%lx,rsp=%d,rsi=%d,rsh=%d,irq=%d,ipmb=%d\n",

		   si_to_str[smi->si_type],

		   addr_space_to_str[smi->io.addr_type],
@@ -3051,6 +3053,8 @@ static int smi_params_proc_show(struct seq_file *m, void *v) 
		   smi->io.regshift,

		   smi->irq,

		   smi->slave_addr);



	return seq_has_overflowed(m);

}



static int smi_params_proc_open(struct inode *inode, struct file *file)

drivers/char/ipmi/ipmi_ssif.c

+3 −1
Original line number Diff line number Diff line
@@ -1196,7 +1196,9 @@ static int ssif_detect(struct i2c_client *client, struct i2c_board_info *info) 


static int smi_type_proc_show(struct seq_file *m, void *v)

{

	return seq_puts(m, "ssif\n");

	seq_puts(m, "ssif\n");



	return seq_has_overflowed(m);

}



static int smi_type_proc_open(struct inode *inode, struct file *file)