Unverified Commit d67a9a26 authored Oct 24, 2023 by openeuler-ci-bot Committed by Gitee Oct 24, 2023

!2334 ktask: add memory leak handling for ktask_works in ktask_init()

Merge Pull Request from: @gemini2045 
 
Hello, I am Gui-Dong Han
from the School of Cyber Science and Technology at Beihang University.
I discovered a possible bug using a program analysis tool
named `BassCheck`, developed by our team.

The pointer `ktask_works` is allocated using `kmalloc_array`,
but is not freed in the error handling code.
This can lead to a memory leak if the initialization process fails.
To address this issue,
the allocated memory for the pointer `ktask_works`
should be freed in the respective error handling code.
 
 
Link:https://gitee.com/openeuler/kernel/pulls/2334

 

Reviewed-by: Xie XiuQi <xiexiuqi@huawei.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>

parents 50eca1df 540cd2b7

kernel/ktask.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -582,6 +582,7 @@ void __init ktask_init(void)
		ktask_wq = alloc_workqueue("ktask_wq", WQ_UNBOUND, 0);
		if (!ktask_wq) {
		pr_warn("disabled (failed to alloc ktask_wq)");
		kfree(ktask_works);
		goto out;
		}

		@@ -633,6 +634,7 @@ void __init ktask_init(void)
		destroy_workqueue(ktask_wq);
		if (ktask_nonuma_wq)
		destroy_workqueue(ktask_nonuma_wq);
		kfree(ktask_works);
		ktask_wq = NULL;
		ktask_nonuma_wq = NULL;
		}