Commit d6660880 authored by Yang Yingliang's avatar Yang Yingliang Committed by Jakub Kicinski
Browse files

octeontx2-af: debugsfs: fix pci device refcount leak 



As comment of pci_get_domain_bus_and_slot() says, it returns
a pci device with refcount increment, when finish using it,
the caller must decrement the reference count by calling
pci_dev_put().

So before returning from rvu_dbg_rvu_pf_cgx_map_display() or
cgx_print_dmac_flt(), pci_dev_put() is called to avoid refcount
leak.

Fixes: dbc52deb ("octeontx2-af: Debugfs support for DMAC filters")
Fixes: e2fb3730 ("octeontx2-af: Display CGX, NIX and PF map in debugfs.")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221117124658.162409-1-yangyingliang@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 62a7311f

drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c

+3 −0
Original line number Diff line number Diff line
@@ -880,6 +880,8 @@ static int rvu_dbg_rvu_pf_cgx_map_display(struct seq_file *filp, void *unused) 
		sprintf(lmac, "LMAC%d", lmac_id);

		seq_printf(filp, "%s\t0x%x\t\tNIX%d\t\t%s\t%s\n",

			   dev_name(&pdev->dev), pcifunc, blkid, cgx, lmac);



		pci_dev_put(pdev);

	}

	return 0;

}
@@ -2566,6 +2568,7 @@ static int cgx_print_dmac_flt(struct seq_file *s, int lmac_id) 
		}

	}



	pci_dev_put(pdev);

	return 0;

}