Commit d645148c authored Dec 19, 2020 by Christophe JAILLET Committed by Vinod Koul Dec 29, 2020

dmaengine: milbeaut-xdmac: Fix a resource leak in the error handling path of the probe function



'disable_xdmac()' should be called in the error handling path of the
probe function to undo a previous 'enable_xdmac()' call, as already
done in the remove function.

Fixes: a6e9be05 ("dmaengine: milbeaut-xdmac: Add XDMAC driver for Milbeaut platforms")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/20201219132800.183254-1-christophe.jaillet@wanadoo.fr


Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 33cbd54d

drivers/dma/milbeaut-xdmac.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -350,7 +350,7 @@ static int milbeaut_xdmac_probe(struct platform_device *pdev)

		ret = dma_async_device_register(ddev);
		if (ret)
		return ret;
		goto disable_xdmac;

		ret = of_dma_controller_register(dev->of_node,
		of_dma_simple_xlate, mdev);
		@@ -363,6 +363,8 @@ static int milbeaut_xdmac_probe(struct platform_device *pdev)

		unregister_dmac:
		dma_async_device_unregister(ddev);
		disable_xdmac:
		disable_xdmac(mdev);
		return ret;
		}