Commit d633b8a7 authored by Damien Le Moal's avatar Damien Le Moal Committed by Jens Axboe
Browse files

libata: print feature list on device scan 



Print a list of features supported by a drive when it is configured in
ata_dev_configure() using the new function ata_dev_print_features().
The features printed are not already advertized and are: trusted
send-recev support, device attention support, device sleep support,
NCQ send-recv support and NCQ priority support.

Signed-off-by: default avatarDamien Le Moal <damien.lemoal@wdc.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Link: https://lore.kernel.org/r/20210816014456.2191776-9-damien.lemoal@wdc.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent fc5c8aa7

drivers/ata/libata-core.c

+17 −0
Original line number Diff line number Diff line
@@ -2433,6 +2433,20 @@ static void ata_dev_config_devslp(struct ata_device *dev) 
	}

}



static void ata_dev_print_features(struct ata_device *dev)

{

	if (!(dev->flags & ATA_DFLAG_FEATURES_MASK))

		return;



	ata_dev_info(dev,

		     "Features:%s%s%s%s%s\n",

		     dev->flags & ATA_DFLAG_TRUSTED ? " Trust" : "",

		     dev->flags & ATA_DFLAG_DA ? " Dev-Attention" : "",

		     dev->flags & ATA_DFLAG_DEVSLP ? " Dev-Sleep" : "",

		     dev->flags & ATA_DFLAG_NCQ_SEND_RECV ? " NCQ-sndrcv" : "",

		     dev->flags & ATA_DFLAG_NCQ_PRIO ? " NCQ-prio" : "");

}



/**

 *	ata_dev_configure - Configure the specified ATA/ATAPI device

 *	@dev: Target device to configure
@@ -2595,6 +2609,9 @@ int ata_dev_configure(struct ata_device *dev) 
		ata_dev_config_zac(dev);

		ata_dev_config_trusted(dev);

		dev->cdb_len = 32;



		if (ata_msg_drv(ap) && print_info)

			ata_dev_print_features(dev);

	}



	/* ATAPI-specific feature tests */

include/linux/libata.h

+4 −0
Original line number Diff line number Diff line
@@ -161,6 +161,10 @@ enum { 
	ATA_DFLAG_D_SENSE	= (1 << 29), /* Descriptor sense requested */

	ATA_DFLAG_ZAC		= (1 << 30), /* ZAC device */



	ATA_DFLAG_FEATURES_MASK	= ATA_DFLAG_TRUSTED | ATA_DFLAG_DA | \

				  ATA_DFLAG_DEVSLP | ATA_DFLAG_NCQ_SEND_RECV | \

				  ATA_DFLAG_NCQ_PRIO,



	ATA_DEV_UNKNOWN		= 0,	/* unknown device */

	ATA_DEV_ATA		= 1,	/* ATA device */

	ATA_DEV_ATA_UNSUP	= 2,	/* ATA device (unsupported) */