Commit d5d8d675 authored by Simon South's avatar Simon South Committed by Thierry Reding
Browse files

pwm: rockchip: rockchip_pwm_probe(): Remove superfluous clk_unprepare() 



If rockchip_pwm_probe() fails to register a PWM device it calls
clk_unprepare() for the device's PWM clock, without having first disabled
the clock and before jumping to an error handler that also unprepares
it. This is likely to produce warnings from the kernel about the clock
being unprepared when it is still enabled, and then being unprepared when
it has already been unprepared.

Prevent these warnings by removing this unnecessary call to
clk_unprepare().

Fixes: 48cf973c ("pwm: rockchip: Avoid glitches on already running PWMs")
Signed-off-by: default avatarSimon South <simon@simonsouth.net>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent d9b657a5

drivers/pwm/pwm-rockchip.c

+0 −1
Original line number Diff line number Diff line
@@ -351,7 +351,6 @@ static int rockchip_pwm_probe(struct platform_device *pdev) 


	ret = pwmchip_add(&pc->chip);

	if (ret < 0) {

		clk_unprepare(pc->clk);

		dev_err(&pdev->dev, "pwmchip_add() failed: %d\n", ret);

		goto err_pclk;

	}