Unverified Commit d5d02359 authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: SOF: Intel: add dev_dbg log when driver is not selected 

Mirror change suggested in legacy HDaudio driver.

On SKL+ Intel platforms, the driver selection is handled by the
snd_intel_dspcfg, and when the HDaudio legacy driver is not selected,
be it with the auto-selection or user preferences with a kernel
parameter, the probe aborts with no logs, only a -ENODEV return value.

Having no dmesg trace, even with dynamic debug enabled, makes support
more complicated than it needs to be, and even experienced users can
be fooled. A simple dev_dbg() trace solves this problem.

BugLink: https://github.com/thesofproject/linux/issues/2330


Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarGuennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200824200912.46852-8-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 71d551f5

sound/soc/sof/sof-pci-dev.c

+3 −3
Original line number Diff line number Diff line
@@ -302,10 +302,10 @@ static int sof_pci_probe(struct pci_dev *pci, 
	int ret;



	ret = snd_intel_dsp_driver_probe(pci);

	if (ret != SND_INTEL_DSP_DRIVER_ANY &&

	    ret != SND_INTEL_DSP_DRIVER_SOF)

	if (ret != SND_INTEL_DSP_DRIVER_ANY && ret != SND_INTEL_DSP_DRIVER_SOF) {

		dev_dbg(&pci->dev, "SOF PCI driver not selected, aborting probe\n");

		return -ENODEV;



	}

	dev_dbg(&pci->dev, "PCI DSP detected");



	/* get ops for platform */