Commit d5c10e0f authored by Dave Jiang's avatar Dave Jiang Committed by Vinod Koul
Browse files

dmaengine: idxd: fix setup sequence for MSIXPERM table 



The MSIX permission table should be programmed BEFORE request_irq()
happens. This prevents any possibility of an interrupt happening before the
MSIX perm table is setup, however slight.

Fixes: 6df0e6c5 ("dmaengine: idxd: clear MSIX permission entry on shutdown")
Sign-off-by: default avatarDave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/162456741222.1138073.1298447364671237896.stgit@djiang5-desk3.ch.intel.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent da435aed

drivers/dma/idxd/init.c

+3 −1
Original line number Diff line number Diff line
@@ -102,6 +102,8 @@ static int idxd_setup_interrupts(struct idxd_device *idxd) 
		spin_lock_init(&idxd->irq_entries[i].list_lock);

	}



	idxd_msix_perm_setup(idxd);



	irq_entry = &idxd->irq_entries[0];

	rc = request_threaded_irq(irq_entry->vector, NULL, idxd_misc_thread,

				  0, "idxd-misc", irq_entry);
@@ -148,7 +150,6 @@ static int idxd_setup_interrupts(struct idxd_device *idxd) 
	}



	idxd_unmask_error_interrupts(idxd);

	idxd_msix_perm_setup(idxd);

	return 0;



 err_wq_irqs:
@@ -162,6 +163,7 @@ static int idxd_setup_interrupts(struct idxd_device *idxd) 
 err_misc_irq:

	/* Disable error interrupt generation */

	idxd_mask_error_interrupts(idxd);

	idxd_msix_perm_clear(idxd);

 err_irq_entries:

	pci_free_irq_vectors(pdev);

	dev_err(dev, "No usable interrupts\n");