Commit d5b7eb47 authored by Andrey Konovalov's avatar Andrey Konovalov Committed by Hans Verkuil
Browse files

media: camss: set VFE bpl_alignment to 16 for sdm845 and sm8250 



From the experiments with camera sensors using SGRBG10_1X10/3280x2464 and
SRGGB10_1X10/3280x2464 formats, it becomes clear that on sdm845 and sm8250
VFE outputs the lines padded to a length multiple of 16 bytes. As in the
current driver the value of the bpl_alignment is set to 8 bytes, the frames
captured in formats with the bytes-per-line value being not a multiple of
16 get corrupted.

Set the bpl_alignment of the camss video output device to 16 for sdm845 and
sm8250 to fix that.

Signed-off-by: default avatarAndrey Konovalov <andrey.konovalov@linaro.org>
Tested-by: default avatarBryan O'Donoghue <bryan.odonoghue@linaro.org>
Acked-by: default avatarBryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent 26ae58f6

drivers/media/platform/qcom/camss/camss-vfe.c

+5 −1
Original line number Diff line number Diff line
@@ -1541,6 +1541,10 @@ int msm_vfe_register_entities(struct vfe_device *vfe, 
		}



		video_out->ops = &vfe->video_ops;

		if (vfe->camss->version == CAMSS_845 ||

		    vfe->camss->version == CAMSS_8250)

			video_out->bpl_alignment = 16;

		else

			video_out->bpl_alignment = 8;

		video_out->line_based = 0;

		if (i == VFE_LINE_PIX) {