Commit d58560e6 authored by Hans de Goede's avatar Hans de Goede Committed by Thierry Reding
Browse files

pwm: lpss: Log error from pwm_lpss_is_updating() if the update bit is still set 



pwm_lpss_is_updating() does a sanity check which should never fail.
If the check does actually fail that is worth logging an error,
especially since this means that we will skip making the requested
changes to the PWM settings.

Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent 5e5da1e9

drivers/pwm/pwm-lpss.c

+6 −1
Original line number Diff line number Diff line
@@ -76,7 +76,12 @@ static int pwm_lpss_wait_for_update(struct pwm_device *pwm) 


static inline int pwm_lpss_is_updating(struct pwm_device *pwm)

{

	return (pwm_lpss_read(pwm) & PWM_SW_UPDATE) ? -EBUSY : 0;

	if (pwm_lpss_read(pwm) & PWM_SW_UPDATE) {

		dev_err(pwm->chip->dev, "PWM_SW_UPDATE is still set, skipping update\n");

		return -EBUSY;

	}



	return 0;

}



static void pwm_lpss_prepare(struct pwm_lpss_chip *lpwm, struct pwm_device *pwm,