Commit d5831bee authored Mar 26, 2021 by Lee Jones Committed by Benjamin Tissoires Apr 07, 2021

HID: intel-ish: Supply some missing param descriptions

Fixes the following W=1 kernel build warning(s):

drivers/hid/intel-ish-hid/ishtp/bus.c:173: warning: Function parameter or member 'fw_client' not described in 'ishtp_get_fw_client_id'
drivers/hid/intel-ish-hid/ishtp/bus.c:845: warning: Function parameter or member 'device' not described in 'ishtp_device'
drivers/hid/intel-ish-hid/ishtp/bus.c:858: warning: Function parameter or member 'device' not described in 'ishtp_get_pci_device'
drivers/hid/intel-ish-hid/ishtp/bus.c:871: warning: Function parameter or member 'cl_device' not described in 'ishtp_trace_callback'
drivers/hid/intel-ish-hid/ishtp/bus.c:884: warning: Function parameter or member 'dev' not described in 'ish_hw_reset'

Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

parent 3977e00e

drivers/hid/intel-ish-hid/ishtp/bus.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -164,6 +164,7 @@ EXPORT_SYMBOL(ishtp_fw_cl_get_client);

		/**
		* ishtp_get_fw_client_id() - Get fw client id
		* @fw_client: firmware client used to fetch the ID
		*
		* This interface is used to reset HW get FW client id.
		*
		@@ -835,6 +836,7 @@ int ishtp_use_dma_transfer(void)

		/**
		* ishtp_device() - Return device pointer
		* @device: ISH-TP client device instance
		*
		* This interface is used to return device pointer from ishtp_cl_device
		* instance.
		@@ -851,6 +853,7 @@ EXPORT_SYMBOL(ishtp_device);
		* ishtp_get_pci_device() - Return PCI device dev pointer
		* This interface is used to return PCI device pointer
		* from ishtp_cl_device instance.
		* @device: ISH-TP client device instance
		*
		* Return: device *.
		*/
		@@ -862,6 +865,7 @@ EXPORT_SYMBOL(ishtp_get_pci_device);

		/**
		* ishtp_trace_callback() - Return trace callback
		* @cl_device: ISH-TP client device instance
		*
		* This interface is used to return trace callback function pointer.
		*
		@@ -875,6 +879,7 @@ EXPORT_SYMBOL(ishtp_trace_callback);

		/**
		* ish_hw_reset() - Call HW reset IPC callback
		* @dev: ISHTP device instance
		*
		* This interface is used to reset HW in case of error.
		*