Commit d5274b3c authored Sep 06, 2018 by Konstantin Khlebnikov Committed by Jens Axboe Sep 06, 2018

block: bfq: swap puts in bfqg_and_blkg_put



Fix trivial use-after-free. This could be last reference to bfqg.

Fixes: 8f9bebc3 ("block, bfq: access and cache blkg data only when safe")
Acked-by: Paolo Valente <paolo.valente@linaro.org>
Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 8b2ded1c

block/bfq-cgroup.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -275,9 +275,9 @@ static void bfqg_and_blkg_get(struct bfq_group *bfqg)

	void bfqg_and_blkg_put(struct bfq_group *bfqg)		void bfqg_and_blkg_put(struct bfq_group *bfqg)
	{		{
	bfqg_put(bfqg);

	blkg_put(bfqg_to_blkg(bfqg));		blkg_put(bfqg_to_blkg(bfqg));

			bfqg_put(bfqg);
	}		}

	/* @stats = 0 */		/* @stats = 0 */