Commit d502933c authored by Cai Huoqing's avatar Cai Huoqing Committed by David S. Miller
Browse files

net: atl1c: Make use of the helper function dev_err_probe() 



When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, and simplify the code.

Signed-off-by: default avatarCai Huoqing <caihuoqing@baidu.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 95b5fc03

drivers/net/ethernet/atheros/atl1c/atl1c_main.c

+2 −4
Original line number Diff line number Diff line
@@ -2662,10 +2662,8 @@ static int atl1c_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 


	/* enable device (incl. PCI PM wakeup and hotplug setup) */

	err = pci_enable_device_mem(pdev);

	if (err) {

		dev_err(&pdev->dev, "cannot enable PCI device\n");

		return err;

	}

	if (err)

		return dev_err_probe(&pdev->dev, err, "cannot enable PCI device\n");



	/*

	 * The atl1c chip can DMA to 64-bit addresses, but it uses a single