Commit d4edb506 authored by Artem Chernyshev's avatar Artem Chernyshev Committed by Jakub Kicinski
Browse files

net: dsa: hellcreek: Check return value 



Return NULL if we got unexpected value from skb_trim_rcsum()
in hellcreek_rcv()

Fixes: 01ef09ca ("net: dsa: Add tag handling for Hirschmann Hellcreek switches")
Signed-off-by: default avatarArtem Chernyshev <artem.chernyshev@red-soft.ru>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Reviewed-by: default avatarKurt Kanzenbach <kurt@linutronix.de>
Link: https://lore.kernel.org/r/20221201140032.26746-2-artem.chernyshev@red-soft.ru


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 3d8fdcbf

net/dsa/tag_hellcreek.c

+2 −1
Original line number Diff line number Diff line
@@ -49,7 +49,8 @@ static struct sk_buff *hellcreek_rcv(struct sk_buff *skb, 
		return NULL;

	}



	pskb_trim_rcsum(skb, skb->len - HELLCREEK_TAG_LEN);

	if (pskb_trim_rcsum(skb, skb->len - HELLCREEK_TAG_LEN))

		return NULL;



	dsa_default_offload_fwd_mark(skb);