Commit d4ec9550 authored by Colin Ian King's avatar Colin Ian King Committed by Mauro Carvalho Chehab
Browse files

media: vivid: fix incorrect assignment operation when setting video mode 



The assigment of FB_VMODE_NONINTERLACE to var->vmode should be a
bit-wise or of FB_VMODE_NONINTERLACE instead of an assignment,
otherwise the previous clearing of the FB_VMODE_MASK bits of
var->vmode makes no sense and is redundant.

Addresses-Coverity: ("Unused value")
Fixes: ad4e02d5 ("[media] vivid: add a simple framebuffer device for overlay testing")

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 0c6280b3

drivers/media/platform/vivid/vivid-osd.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -155,7 +155,7 @@ static int _vivid_fb_check_var(struct fb_var_screeninfo *var, struct vivid_dev * 
	var->nonstd = 0;

	var->nonstd = 0;





	var->vmode &= ~FB_VMODE_MASK;

	var->vmode &= ~FB_VMODE_MASK;

	var->vmode = FB_VMODE_NONINTERLACED;

	var->vmode |= FB_VMODE_NONINTERLACED;





	/* Dummy values */

	/* Dummy values */

	var->hsync_len = 24;

	var->hsync_len = 24;