Commit d4ebfca2 authored by James Morse's avatar James Morse Committed by Borislav Petkov
Browse files

x86/resctrl: Fix kfree() of the wrong type in domain_add_cpu() 



Commit in Fixes separated the architecture specific and filesystem parts
of the resctrl domain structures.

This left the error paths in domain_add_cpu() kfree()ing the memory with
the wrong type.

This will cause a problem if someone adds a new member to struct
rdt_hw_domain meaning d_resctrl is no longer the first member.

Fixes: 792e0f6f ("x86/resctrl: Split struct rdt_domain")
Signed-off-by: default avatarJames Morse <james.morse@arm.com>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Acked-by: default avatarReinette Chatre <reinette.chatre@intel.com>
Link: https://lkml.kernel.org/r/20210917165924.28254-1-james.morse@arm.com
parent 64e87d4b

arch/x86/kernel/cpu/resctrl/core.c

+2 −2
Original line number Diff line number Diff line
@@ -527,14 +527,14 @@ static void domain_add_cpu(int cpu, struct rdt_resource *r) 
	rdt_domain_reconfigure_cdp(r);



	if (r->alloc_capable && domain_setup_ctrlval(r, d)) {

		kfree(d);

		kfree(hw_dom);

		return;

	}



	if (r->mon_capable && domain_setup_mon_state(r, d)) {

		kfree(hw_dom->ctrl_val);

		kfree(hw_dom->mbps_val);

		kfree(d);

		kfree(hw_dom);

		return;

	}