Commit d4e82cf4 authored by Aya Levin's avatar Aya Levin Committed by David S. Miller
Browse files

net/mlx5: Dump of fw_fatal use updated devlink binary interface 



Remove redundant code from fw_fatal reporter's dump callback. Use
updated devlink interface of binary fmsg pair which breaks the output
into chunks internally.

Signed-off-by: default avatarAya Levin <ayal@mellanox.com>
Acked-by: default avatarJiri Pirko <jiri@mellanox.com>
Acked-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e2cde864

drivers/net/ethernet/mellanox/mlx5/core/health.c

+1 −17
Original line number Diff line number Diff line
@@ -555,7 +555,6 @@ mlx5_fw_fatal_reporter_recover(struct devlink_health_reporter *reporter, 
	return mlx5_health_try_recover(dev);

}



#define MLX5_CR_DUMP_CHUNK_SIZE 256

static int

mlx5_fw_fatal_reporter_dump(struct devlink_health_reporter *reporter,

			    struct devlink_fmsg *fmsg, void *priv_ctx,
@@ -564,8 +563,6 @@ mlx5_fw_fatal_reporter_dump(struct devlink_health_reporter *reporter, 
	struct mlx5_core_dev *dev = devlink_health_reporter_priv(reporter);

	u32 crdump_size = dev->priv.health.crdump_size;

	u32 *cr_data;

	u32 data_size;

	u32 offset;

	int err;



	if (!mlx5_core_is_pf(dev))
@@ -586,20 +583,7 @@ mlx5_fw_fatal_reporter_dump(struct devlink_health_reporter *reporter, 
			goto free_data;

	}



	err = devlink_fmsg_arr_pair_nest_start(fmsg, "crdump_data");

	if (err)

		goto free_data;

	for (offset = 0; offset < crdump_size; offset += data_size) {

		if (crdump_size - offset < MLX5_CR_DUMP_CHUNK_SIZE)

			data_size = crdump_size - offset;

		else

			data_size = MLX5_CR_DUMP_CHUNK_SIZE;

		err = devlink_fmsg_binary_put(fmsg, (char *)cr_data + offset,

					      data_size);

		if (err)

			goto free_data;

	}

	err = devlink_fmsg_arr_pair_nest_end(fmsg);

	err = devlink_fmsg_binary_pair_put(fmsg, "crdump_data", cr_data, crdump_size);



free_data:

	kvfree(cr_data);