Commit d4b561c3 authored by Sebastian Reichel's avatar Sebastian Reichel Committed by Tomi Valkeinen
Browse files

drm/omap: dsi: drop useless sync() 



The DSI sync() function only locks the bus and then releases
it again. Currently the only invocation is directly before
update(), which locks the bus anyways.

Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201215104657.802264-21-tomi.valkeinen@ti.com
parent 8228cd7e

drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c

+0 −18
Original line number Diff line number Diff line
@@ -844,23 +844,6 @@ static int dsicm_update(struct omap_dss_device *dssdev, 
	return r;

}



static int dsicm_sync(struct omap_dss_device *dssdev)

{

	struct panel_drv_data *ddata = to_panel_data(dssdev);

	struct omap_dss_device *src = ddata->src;



	dev_dbg(&ddata->dsi->dev, "sync\n");



	mutex_lock(&ddata->lock);

	src->ops->dsi.bus_lock(src);

	src->ops->dsi.bus_unlock(src);

	mutex_unlock(&ddata->lock);



	dev_dbg(&ddata->dsi->dev, "sync done\n");



	return 0;

}



static int _dsicm_enable_te(struct panel_drv_data *ddata, bool enable)

{

	struct omap_dss_device *src = ddata->src;
@@ -949,7 +932,6 @@ static const struct omap_dss_device_ops dsicm_ops = { 


static const struct omap_dss_driver dsicm_dss_driver = {

	.update		= dsicm_update,

	.sync		= dsicm_sync,

};



static int dsicm_probe_of(struct mipi_dsi_device *dsi)

drivers/gpu/drm/omapdrm/dss/omapdss.h

+0 −1
Original line number Diff line number Diff line
@@ -388,7 +388,6 @@ struct omap_dss_device { 
struct omap_dss_driver {

	int (*update)(struct omap_dss_device *dssdev,

			       u16 x, u16 y, u16 w, u16 h);

	int (*sync)(struct omap_dss_device *dssdev);

};



struct dss_device *omapdss_get_dss(void);

drivers/gpu/drm/omapdrm/omap_crtc.c

+0 −3
Original line number Diff line number Diff line
@@ -379,9 +379,6 @@ static void omap_crtc_manual_display_update(struct work_struct *data) 
		return;

	}



	if (dssdrv->sync)

		dssdrv->sync(dssdev);



	ret = dssdrv->update(dssdev, 0, 0, mode->hdisplay, mode->vdisplay);

	if (ret < 0) {

		spin_lock_irq(&dev->event_lock);