Commit d4955c0a authored by Sergey Shtylyov's avatar Sergey Shtylyov Committed by Will Deacon
Browse files

arm64: topology: fix possible overflow in amu_fie_setup() 



cpufreq_get_hw_max_freq() returns max frequency in kHz as *unsigned int*,
while freq_inv_set_max_ratio() gets passed this frequency in Hz as 'u64'.
Multiplying max frequency by 1000 can potentially result in overflow --
multiplying by 1000ULL instead should avoid that...

Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.

Fixes: cd0ed03a ("arm64: use activity monitors for frequency invariance")
Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Link: https://lore.kernel.org/r/01493d64-2bce-d968-86dc-11a122a9c07d@omp.ru


Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent 61d2d180

arch/arm64/kernel/topology.c

+1 −1
Original line number Diff line number Diff line
@@ -237,7 +237,7 @@ static void amu_fie_setup(const struct cpumask *cpus) 
	for_each_cpu(cpu, cpus) {

		if (!freq_counters_valid(cpu) ||

		    freq_inv_set_max_ratio(cpu,

					   cpufreq_get_hw_max_freq(cpu) * 1000,

					   cpufreq_get_hw_max_freq(cpu) * 1000ULL,

					   arch_timer_get_rate()))

			return;

	}