Commit d48cefbb authored by Yihang Li's avatar Yihang Li Committed by xia-bing1
Browse files

scsi: hisi_sas: Add firmware information check 

driver inclusion
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IB5FF2


CVE: NA

---------------------------------------------------------------------

For security purposes, after information is obtained through the FW,
check information to ensure data correctness.

 - In v1 and v2 hw, the maximum number of PHYs is 9, while in v3 it is 8.

 - In v2 and v3 hw, the maximum number of hardware queues is 16, while
   in v1 it is 32.

Also add some debug logs for failure.

Fixes: e21fe3a5 ("scsi: hisi_sas: add initialisation for v3 pci-based controller")
Signed-off-by: default avatarYihang Li <liyihang9@huawei.com>
Link: https://lore.kernel.org/r/20241008021822.2617339-4-liyihang9@huawei.com


Reviewed-by: default avatarXiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarBing Xia <xiabing12@h-partners.com>
parent 8208d1a0

drivers/scsi/hisi_sas/hisi_sas.h

+1 −0
Original line number Diff line number Diff line
@@ -307,6 +307,7 @@ enum { 


struct hisi_sas_hw {

	int (*hw_init)(struct hisi_hba *hisi_hba);

	int (*fw_info_check)(struct hisi_hba *hisi_hba);

	int (*interrupt_preinit)(struct hisi_hba *hisi_hba);

	void (*setup_itct)(struct hisi_hba *hisi_hba,

			   struct hisi_sas_device *device);

drivers/scsi/hisi_sas/hisi_sas_main.c

+5 −0
Original line number Diff line number Diff line
@@ -2431,6 +2431,11 @@ static struct Scsi_Host *hisi_sas_shost_alloc(struct platform_device *pdev, 
	if (hisi_sas_get_fw_info(hisi_hba) < 0)

		goto err_out;



	if (hisi_hba->hw->fw_info_check) {

		if (hisi_hba->hw->fw_info_check(hisi_hba))

			goto err_out;

	}



	error = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));

	if (error) {

		dev_err(dev, "No usable DMA addressing method\n");

drivers/scsi/hisi_sas/hisi_sas_v1_hw.c

+18 −0
Original line number Diff line number Diff line
@@ -1734,6 +1734,23 @@ static struct attribute *host_v1_hw_attrs[] = { 


ATTRIBUTE_GROUPS(host_v1_hw);



static int check_fw_info_v1_hw(struct hisi_hba *hisi_hba)

{

	struct device *dev = hisi_hba->dev;



	if (hisi_hba->n_phy < 0 || hisi_hba->n_phy > 9) {

		dev_err(dev, "invalid phy number from FW\n");

		return -EINVAL;

	}



	if (hisi_hba->queue_count < 0 || hisi_hba->queue_count > 32) {

		dev_err(dev, "invalid queue count from FW\n");

		return -EINVAL;

	}



	return 0;

}



static const struct scsi_host_template sht_v1_hw = {

	.name			= DRV_NAME,

	.proc_name		= DRV_NAME,
@@ -1763,6 +1780,7 @@ static const struct scsi_host_template sht_v1_hw = { 


static const struct hisi_sas_hw hisi_sas_v1_hw = {

	.hw_init = hisi_sas_v1_init,

	.fw_info_check = check_fw_info_v1_hw,

	.setup_itct = setup_itct_v1_hw,

	.sl_notify_ssp = sl_notify_ssp_v1_hw,

	.clear_itct = clear_itct_v1_hw,

drivers/scsi/hisi_sas/hisi_sas_v2_hw.c

+18 −0
Original line number Diff line number Diff line
@@ -3561,6 +3561,23 @@ static void map_queues_v2_hw(struct Scsi_Host *shost) 
	}

}



static int check_fw_info_v2_hw(struct hisi_hba *hisi_hba)

{

	struct device *dev = hisi_hba->dev;



	if (hisi_hba->n_phy < 0 || hisi_hba->n_phy > 9) {

		dev_err(dev, "invalid phy number from FW\n");

		return -EINVAL;

	}



	if (hisi_hba->queue_count < 0 || hisi_hba->queue_count > 16) {

		dev_err(dev, "invalid queue count from FW\n");

		return -EINVAL;

	}



	return 0;

}



static const struct scsi_host_template sht_v2_hw = {

	.name			= DRV_NAME,

	.proc_name		= DRV_NAME,
@@ -3592,6 +3609,7 @@ static const struct scsi_host_template sht_v2_hw = { 


static const struct hisi_sas_hw hisi_sas_v2_hw = {

	.hw_init = hisi_sas_v2_init,

	.fw_info_check = check_fw_info_v2_hw,

	.interrupt_preinit = hisi_sas_v2_interrupt_preinit,

	.setup_itct = setup_itct_v2_hw,

	.slot_index_alloc = slot_index_alloc_quirk_v2_hw,

drivers/scsi/hisi_sas/hisi_sas_v3_hw.c

+20 −0
Original line number Diff line number Diff line
@@ -3390,6 +3390,23 @@ static const struct hisi_sas_hw hisi_sas_v3_hw = { 
	.debugfs_snapshot_regs = debugfs_snapshot_regs_v3_hw,

};



static int check_fw_info_v3_hw(struct hisi_hba *hisi_hba)

{

	struct device *dev = hisi_hba->dev;



	if (hisi_hba->n_phy < 0 || hisi_hba->n_phy > 8) {

		dev_err(dev, "invalid phy number from FW\n");

		return -EINVAL;

	}



	if (hisi_hba->queue_count < 0 || hisi_hba->queue_count > 16) {

		dev_err(dev, "invalid queue count from FW\n");

		return -EINVAL;

	}



	return 0;

}



static struct Scsi_Host *

hisi_sas_shost_alloc_pci(struct pci_dev *pdev)

{
@@ -3420,6 +3437,9 @@ hisi_sas_shost_alloc_pci(struct pci_dev *pdev) 
	if (hisi_sas_get_fw_info(hisi_hba) < 0)

		goto err_out;



	if (check_fw_info_v3_hw(hisi_hba) < 0)

		goto err_out;



	if (experimental_iopoll_q_cnt < 0 ||

		experimental_iopoll_q_cnt >= hisi_hba->queue_count)

		dev_err(dev, "iopoll queue count %d cannot exceed or equal 16, using default 0\n",