Commit d4545bf9 authored Feb 08, 2023 by Andy Shevchenko Committed by Jakub Kicinski Feb 09, 2023

genetlink: Use string_is_terminated() helper



Use string_is_terminated() helper instead of cpecific memchr() call.
This shows better the intention of the call.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/20230208133153.22528-2-andriy.shevchenko@linux.intel.com


Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent f1db99c0

net/netlink/genetlink.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -13,7 +13,7 @@
		#include <linux/errno.h>
		#include <linux/types.h>
		#include <linux/socket.h>
		#include <linux/string.h>
		#include <linux/string_helpers.h>
		#include <linux/skbuff.h>
		#include <linux/mutex.h>
		#include <linux/bitmap.h>
		@@ -457,7 +457,7 @@ static int genl_validate_assign_mc_groups(struct genl_family *family)

		if (WARN_ON(grp->name[0] == '\0'))
		return -EINVAL;
		if (WARN_ON(memchr(grp->name, '\0', GENL_NAMSIZ) == NULL))
		if (WARN_ON(!string_is_terminated(grp->name, GENL_NAMSIZ)))
		return -EINVAL;
		}