Commit d43efddf authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Martin K. Petersen
Browse files

scsi: hisi_sas: Remove some useless code in hisi_sas_alloc() 

The 'hisi_hba->slot_index_tags' bitmap is allocated with bitmap_zalloc() so
it is already cleared. There is no need to clear it another time, one bit
at a time.

Remove the corresponding useless code.

Link: https://lore.kernel.org/r/41c86e7e3e05a13bd586d8ee1b81296140b7a6eb.1637961191.git.christophe.jaillet@wanadoo.fr


Acked-by: default avatarJohn Garry <john.garry@huawei.com>
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 54585ec6

drivers/scsi/hisi_sas/hisi_sas_main.c

+0 −9
Original line number Diff line number Diff line
@@ -206,14 +206,6 @@ static int hisi_sas_slot_index_alloc(struct hisi_hba *hisi_hba, 
	return index;

}



static void hisi_sas_slot_index_init(struct hisi_hba *hisi_hba)

{

	int i;



	for (i = 0; i < hisi_hba->slot_index_count; ++i)

		hisi_sas_slot_index_clear(hisi_hba, i);

}



void hisi_sas_slot_task_free(struct hisi_hba *hisi_hba, struct sas_task *task,

			     struct hisi_sas_slot *slot)

{
@@ -2535,7 +2527,6 @@ int hisi_sas_alloc(struct hisi_hba *hisi_hba) 
	if (!hisi_hba->sata_breakpoint)

		goto err_out;



	hisi_sas_slot_index_init(hisi_hba);

	hisi_hba->last_slot_index = HISI_SAS_UNRESERVED_IPTT;



	hisi_hba->wq = create_singlethread_workqueue(dev_name(dev));