Commit d41b26d8 authored by Colin Ian King's avatar Colin Ian King Committed by Juergen Gross
Browse files

xen/gntdev: remove redundant non-zero check on ret 



The non-zero check on ret is always going to be false because
ret was initialized as zero and the only place it is set to
non-zero contains a return path before the non-zero check. Hence
the check is redundant and can be removed.

[ jgross@suse.com: limit scope of ret ]

Addresses-Coverity: ("Logically dead code")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarJuergen Gross <jgross@suse.com>
Signed-off-by: default avatarJuergen Gross <jgross@suse.com>
parent 348be433

drivers/xen/gntdev.c

+2 −7
Original line number Diff line number Diff line
@@ -506,7 +506,6 @@ static const struct mmu_interval_notifier_ops gntdev_mmu_ops = { 
static int gntdev_open(struct inode *inode, struct file *flip)

{

	struct gntdev_priv *priv;

	int ret = 0;



	priv = kzalloc(sizeof(*priv), GFP_KERNEL);

	if (!priv)
@@ -518,16 +517,12 @@ static int gntdev_open(struct inode *inode, struct file *flip) 
#ifdef CONFIG_XEN_GNTDEV_DMABUF

	priv->dmabuf_priv = gntdev_dmabuf_init(flip);

	if (IS_ERR(priv->dmabuf_priv)) {

		ret = PTR_ERR(priv->dmabuf_priv);

		kfree(priv);

		return ret;

	}

#endif

		int ret = PTR_ERR(priv->dmabuf_priv);



	if (ret) {

		kfree(priv);

		return ret;

	}

#endif



	flip->private_data = priv;

#ifdef CONFIG_XEN_GRANT_DMA_ALLOC