Unverified Commit d4073595 authored by Dan Carpenter's avatar Dan Carpenter Committed by Konstantin Komarov
Browse files

fs/ntfs3: uninitialized variable in ntfs_set_acl_ex() 



The goto out calls kfree(value) on an uninitialized pointer.  Just
return directly as the other error paths do.

Fixes: 460bbf29 ("fs/ntfs3: Do not change mode if ntfs_set_ea failed")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
parent 96964352

fs/ntfs3/xattr.c

+1 −1
Original line number Diff line number Diff line
@@ -568,7 +568,7 @@ static noinline int ntfs_set_acl_ex(struct user_namespace *mnt_userns, 
			err = posix_acl_update_mode(mnt_userns, inode, &mode,

						    &acl);

			if (err)

				goto out;

				return err;

		}

		name = XATTR_NAME_POSIX_ACL_ACCESS;

		name_len = sizeof(XATTR_NAME_POSIX_ACL_ACCESS) - 1;