Commit d3de970b authored by Dan Carpenter's avatar Dan Carpenter Committed by Richard Weinberger
Browse files

ubifs: fix snprintf() length check 



The snprintf() function returns the number of bytes (not including the
NUL terminator) which would have been printed if there were enough
space.  So it can be greater than UBIFS_DFS_DIR_LEN.  And actually if
it equals UBIFS_DFS_DIR_LEN then that's okay so this check is too
strict.

Fixes: 9a620291fc01 ("ubifs: Export filesystem error counters")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
parent 58225631

fs/ubifs/sysfs.c

+1 −1
Original line number Diff line number Diff line
@@ -100,7 +100,7 @@ int ubifs_sysfs_register(struct ubifs_info *c) 
	n = snprintf(dfs_dir_name, UBIFS_DFS_DIR_LEN + 1, UBIFS_DFS_DIR_NAME,

		     c->vi.ubi_num, c->vi.vol_id);



	if (n == UBIFS_DFS_DIR_LEN) {

	if (n > UBIFS_DFS_DIR_LEN) {

		/* The array size is too small */

		ret = -EINVAL;

		goto out_free;