Commit d3d854fd authored by Jakub Kicinski's avatar Jakub Kicinski Committed by Alexei Starovoitov
Browse files

netdev-genl: create a simple family for netdev stuff 



Add a Netlink spec-compatible family for netdevs.
This is a very simple implementation without much
thought going into it.

It allows us to reap all the benefits of Netlink specs,
one can use the generic client to issue the commands:

  $ ./cli.py --spec netdev.yaml --dump dev_get
  [{'ifindex': 1, 'xdp-features': set()},
   {'ifindex': 2, 'xdp-features': {'basic', 'ndo-xmit', 'redirect'}},
   {'ifindex': 3, 'xdp-features': {'rx-sg'}}]

the generic python library does not have flags-by-name
support, yet, but we also don't have to carry strings
in the messages, as user space can get the names from
the spec.

Acked-by: default avatarJesper Dangaard Brouer <brouer@redhat.com>
Co-developed-by: default avatarLorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: default avatarLorenzo Bianconi <lorenzo@kernel.org>
Co-developed-by: default avatarKumar Kartikeya Dwivedi <memxor@gmail.com>
Signed-off-by: default avatarKumar Kartikeya Dwivedi <memxor@gmail.com>
Co-developed-by: default avatarMarek Majtyka <alardam@gmail.com>
Signed-off-by: default avatarMarek Majtyka <alardam@gmail.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Link: https://lore.kernel.org/r/327ad9c9868becbe1e601b580c962549c8cd81f2.1675245258.git.lorenzo@kernel.org


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent 15080908

Documentation/netlink/specs/netdev.yaml

0 → 100644
+100 −0
Original line number Diff line number Diff line 
name: netdev



doc:

  netdev configuration over generic netlink.



definitions:

  -

    type: flags

    name: xdp-act

    entries:

      -

        name: basic

        doc:

          XDP feautues set supported by all drivers

          (XDP_ABORTED, XDP_DROP, XDP_PASS, XDP_TX)

      -

        name: redirect

        doc:

          The netdev supports XDP_REDIRECT

      -

        name: ndo-xmit

        doc:

          This feature informs if netdev implements ndo_xdp_xmit callback.

      -

        name: xsk-zerocopy

        doc:

          This feature informs if netdev supports AF_XDP in zero copy mode.

      -

        name: hw-offload

        doc:

         This feature informs if netdev supports XDP hw oflloading.

      -

        name: rx-sg

        doc:

          This feature informs if netdev implements non-linear XDP buffer

          support in the driver napi callback.

      -

        name: ndo-xmit-sg

        doc:

          This feature informs if netdev implements non-linear XDP buffer

          support in ndo_xdp_xmit callback.



attribute-sets:

  -

    name: dev

    attributes:

      -

        name: ifindex

        doc: netdev ifindex

        type: u32

        value: 1

        checks:

          min: 1

      -

        name: pad

        type: pad

      -

        name: xdp-features

        doc: Bitmask of enabled xdp-features.

        type: u64

        enum: xdp-act

        enum-as-flags: true



operations:

  list:

    -

      name: dev-get

      doc: Get / dump information about a netdev.

      value: 1

      attribute-set: dev

      do:

        request:

          attributes:

            - ifindex

        reply: &dev-all

          attributes:

            - ifindex

            - xdp-features

      dump:

        reply: *dev-all

    -

      name: dev-add-ntf

      doc: Notification about device appearing.

      notify: dev-get

      mcgrp: mgmt

    -

      name: dev-del-ntf

      doc: Notification about device disappearing.

      notify: dev-get

      mcgrp: mgmt

    -

      name: dev-change-ntf

      doc: Notification about device configuration being changed.

      notify: dev-get

      mcgrp: mgmt



mcast-groups:

  list:

    -

      name: mgmt

include/linux/netdevice.h

+3 −0
Original line number Diff line number Diff line
@@ -47,6 +47,7 @@ 
#include <uapi/linux/netdevice.h>

#include <uapi/linux/if_bonding.h>

#include <uapi/linux/pkt_cls.h>

#include <uapi/linux/netdev.h>

#include <linux/hashtable.h>

#include <linux/rbtree.h>

#include <net/net_trackers.h>
@@ -2055,6 +2056,7 @@ struct net_device { 


	/* Read-mostly cache-line for fast-path access */

	unsigned int		flags;

	xdp_features_t		xdp_features;

	unsigned long long	priv_flags;

	const struct net_device_ops *netdev_ops;

	const struct xdp_metadata_ops *xdp_metadata_ops;
@@ -2839,6 +2841,7 @@ enum netdev_cmd { 
	NETDEV_OFFLOAD_XSTATS_DISABLE,

	NETDEV_OFFLOAD_XSTATS_REPORT_USED,

	NETDEV_OFFLOAD_XSTATS_REPORT_DELTA,

	NETDEV_XDP_FEAT_CHANGE,

};

const char *netdev_cmd_to_name(enum netdev_cmd cmd);

include/net/xdp.h

+3 −0
Original line number Diff line number Diff line
@@ -7,6 +7,7 @@ 
#define __LINUX_NET_XDP_H__



#include <linux/skbuff.h> /* skb_shared_info */

#include <uapi/linux/netdev.h>



/**

 * DOC: XDP RX-queue information
@@ -43,6 +44,8 @@ enum xdp_mem_type { 
	MEM_TYPE_MAX,

};



typedef u32 xdp_features_t;



/* XDP flags for ndo_xdp_xmit */

#define XDP_XMIT_FLUSH		(1U << 0)	/* doorbell signal consumer */

#define XDP_XMIT_FLAGS_MASK	XDP_XMIT_FLUSH

include/uapi/linux/netdev.h

0 → 100644
+59 −0
Original line number Diff line number Diff line 
/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */

/* Do not edit directly, auto-generated from: */

/*	Documentation/netlink/specs/netdev.yaml */

/* YNL-GEN uapi header */



#ifndef _UAPI_LINUX_NETDEV_H

#define _UAPI_LINUX_NETDEV_H



#define NETDEV_FAMILY_NAME	"netdev"

#define NETDEV_FAMILY_VERSION	1



/**

 * enum netdev_xdp_act

 * @NETDEV_XDP_ACT_BASIC: XDP feautues set supported by all drivers

 *   (XDP_ABORTED, XDP_DROP, XDP_PASS, XDP_TX)

 * @NETDEV_XDP_ACT_REDIRECT: The netdev supports XDP_REDIRECT

 * @NETDEV_XDP_ACT_NDO_XMIT: This feature informs if netdev implements

 *   ndo_xdp_xmit callback.

 * @NETDEV_XDP_ACT_XSK_ZEROCOPY: This feature informs if netdev supports AF_XDP

 *   in zero copy mode.

 * @NETDEV_XDP_ACT_HW_OFFLOAD: This feature informs if netdev supports XDP hw

 *   oflloading.

 * @NETDEV_XDP_ACT_RX_SG: This feature informs if netdev implements non-linear

 *   XDP buffer support in the driver napi callback.

 * @NETDEV_XDP_ACT_NDO_XMIT_SG: This feature informs if netdev implements

 *   non-linear XDP buffer support in ndo_xdp_xmit callback.

 */

enum netdev_xdp_act {

	NETDEV_XDP_ACT_BASIC = 1,

	NETDEV_XDP_ACT_REDIRECT = 2,

	NETDEV_XDP_ACT_NDO_XMIT = 4,

	NETDEV_XDP_ACT_XSK_ZEROCOPY = 8,

	NETDEV_XDP_ACT_HW_OFFLOAD = 16,

	NETDEV_XDP_ACT_RX_SG = 32,

	NETDEV_XDP_ACT_NDO_XMIT_SG = 64,

};



enum {

	NETDEV_A_DEV_IFINDEX = 1,

	NETDEV_A_DEV_PAD,

	NETDEV_A_DEV_XDP_FEATURES,



	__NETDEV_A_DEV_MAX,

	NETDEV_A_DEV_MAX = (__NETDEV_A_DEV_MAX - 1)

};



enum {

	NETDEV_CMD_DEV_GET = 1,

	NETDEV_CMD_DEV_ADD_NTF,

	NETDEV_CMD_DEV_DEL_NTF,

	NETDEV_CMD_DEV_CHANGE_NTF,



	__NETDEV_CMD_MAX,

	NETDEV_CMD_MAX = (__NETDEV_CMD_MAX - 1)

};



#define NETDEV_MCGRP_MGMT	"mgmt"



#endif /* _UAPI_LINUX_NETDEV_H */

net/core/Makefile

+2 −1
Original line number Diff line number Diff line
@@ -12,7 +12,8 @@ obj-$(CONFIG_SYSCTL) += sysctl_net_core.o 
obj-y		     += dev.o dev_addr_lists.o dst.o netevent.o \

			neighbour.o rtnetlink.o utils.o link_watch.o filter.o \

			sock_diag.o dev_ioctl.o tso.o sock_reuseport.o \

			fib_notifier.o xdp.o flow_offload.o gro.o

			fib_notifier.o xdp.o flow_offload.o gro.o \

			netdev-genl.o netdev-genl-gen.o



obj-$(CONFIG_NETDEV_ADDR_LIST_TEST) += dev_addr_lists_test.o