Commit d3ce1979 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Greg Kroah-Hartman
Browse files

sysfs: Use local reference in compat_only_sysfs_link_entry_to_kobj() 



As we have just obtained target_kobj->sd into a local variable, and
incremented the object's reference count, it is better to use the local
variable instead of the original reference.

Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Link: https://lore.kernel.org/r/20210714151559.2532572-1-geert@linux-m68k.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fe968ca2

fs/sysfs/group.c

+1 −1
Original line number Diff line number Diff line
@@ -446,7 +446,7 @@ int compat_only_sysfs_link_entry_to_kobj(struct kobject *kobj, 
	if (!target)

		return -ENOENT;



	entry = kernfs_find_and_get(target_kobj->sd, target_name);

	entry = kernfs_find_and_get(target, target_name);

	if (!entry) {

		kernfs_put(target);

		return -ENOENT;