Commit d3b60ed9 authored by Lukasz Luba's avatar Lukasz Luba Committed by Daniel Lezcano
Browse files

thermal/core/power_allocator: Maintain the device statistics from going stale 



When the temperature is below the first activation trip point the cooling
devices are not checked, so they cannot maintain fresh statistics. It
leads into the situation, when temperature crosses first trip point, the
statistics are stale and show state for very long period. This has impact
on IPA algorithm calculation and wrong decisions. Thus, check the cooling
devices even when the temperature is low, to refresh these statistics.

Signed-off-by: default avatarLukasz Luba <lukasz.luba@arm.com>
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210422114308.29684-3-lukasz.luba@arm.com
parent b70dbf40

drivers/thermal/gov_power_allocator.c

+10 −0
Original line number Diff line number Diff line
@@ -575,15 +575,25 @@ static void allow_maximum_power(struct thermal_zone_device *tz) 
{

	struct thermal_instance *instance;

	struct power_allocator_params *params = tz->governor_data;

	u32 req_power;



	mutex_lock(&tz->lock);

	list_for_each_entry(instance, &tz->thermal_instances, tz_node) {

		struct thermal_cooling_device *cdev = instance->cdev;



		if ((instance->trip != params->trip_max_desired_temperature) ||

		    (!cdev_is_power_actor(instance->cdev)))

			continue;



		instance->target = 0;

		mutex_lock(&instance->cdev->lock);

		/*

		 * Call for updating the cooling devices local stats and avoid

		 * periods of dozen of seconds when those have not been

		 * maintained.

		 */

		cdev->ops->get_requested_power(cdev, &req_power);



		instance->cdev->updated = false;

		mutex_unlock(&instance->cdev->lock);

		thermal_cdev_update(instance->cdev);