Commit d3aeb44c authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Dmitry Torokhov
Browse files

Input: sis_i2c - simplify with dev_err_probe() 



Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20230625162817.100397-20-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 21142c1c

drivers/input/touchscreen/sis_i2c.c

+6 −14
Original line number Diff line number Diff line
@@ -310,23 +310,15 @@ static int sis_ts_probe(struct i2c_client *client) 


	ts->attn_gpio = devm_gpiod_get_optional(&client->dev,

						"attn", GPIOD_IN);

	if (IS_ERR(ts->attn_gpio)) {

		error = PTR_ERR(ts->attn_gpio);

		if (error != -EPROBE_DEFER)

			dev_err(&client->dev,

				"Failed to get attention GPIO: %d\n", error);

		return error;

	}

	if (IS_ERR(ts->attn_gpio))

		return dev_err_probe(&client->dev, PTR_ERR(ts->attn_gpio),

				     "Failed to get attention GPIO\n");



	ts->reset_gpio = devm_gpiod_get_optional(&client->dev,

						 "reset", GPIOD_OUT_LOW);

	if (IS_ERR(ts->reset_gpio)) {

		error = PTR_ERR(ts->reset_gpio);

		if (error != -EPROBE_DEFER)

			dev_err(&client->dev,

				"Failed to get reset GPIO: %d\n", error);

		return error;

	}

	if (IS_ERR(ts->reset_gpio))

		return dev_err_probe(&client->dev, PTR_ERR(ts->reset_gpio),

				     "Failed to get reset GPIO\n");



	sis_ts_reset(ts);