Commit d3ae6918 authored by Johannes Berg's avatar Johannes Berg
Browse files

wifi: iwlwifi: fw: fix DBGI dump 



The DBGI dump is (unsurprisingly) of type DBGI, not SRAM.
This leads to bad register accesses because the union is
built differently, there's no allocation ID, and thus the
allocation ID ends up being 0x8000.

Note that this was already wrong for DRAM vs. SMEM since
they use different parts of the union, but the allocation
ID is at the same place, so it worked.

Fix all of this but set the allocation ID in a way that
the offset calculation ends up without any offset.

Fixes: 34bc2778 ("iwlwifi: yoyo: fix DBGI_SRAM ini dump header.")
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarGregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230514120631.19a302ae4c65.I12272599f7c1930666157b9d5e7f81fe9ec4c421@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 204bfec9

drivers/net/wireless/intel/iwlwifi/fw/dbg.c

+11 −8
Original line number Diff line number Diff line
@@ -1664,14 +1664,10 @@ static __le32 iwl_get_mon_reg(struct iwl_fw_runtime *fwrt, u32 alloc_id, 
}



static void *

iwl_dump_ini_mon_fill_header(struct iwl_fw_runtime *fwrt,

			     struct iwl_dump_ini_region_data *reg_data,

iwl_dump_ini_mon_fill_header(struct iwl_fw_runtime *fwrt, u32 alloc_id,

			     struct iwl_fw_ini_monitor_dump *data,

			     const struct iwl_fw_mon_regs *addrs)

{

	struct iwl_fw_ini_region_tlv *reg = (void *)reg_data->reg_tlv->data;

	u32 alloc_id = le32_to_cpu(reg->dram_alloc_id);



	if (!iwl_trans_grab_nic_access(fwrt->trans)) {

		IWL_ERR(fwrt, "Failed to get monitor header\n");

		return NULL;
@@ -1702,8 +1698,10 @@ iwl_dump_ini_mon_dram_fill_header(struct iwl_fw_runtime *fwrt, 
				  void *data, u32 data_len)

{

	struct iwl_fw_ini_monitor_dump *mon_dump = (void *)data;

	struct iwl_fw_ini_region_tlv *reg = (void *)reg_data->reg_tlv->data;

	u32 alloc_id = le32_to_cpu(reg->dram_alloc_id);



	return iwl_dump_ini_mon_fill_header(fwrt, reg_data, mon_dump,

	return iwl_dump_ini_mon_fill_header(fwrt, alloc_id, mon_dump,

					    &fwrt->trans->cfg->mon_dram_regs);

}
@@ -1713,8 +1711,10 @@ iwl_dump_ini_mon_smem_fill_header(struct iwl_fw_runtime *fwrt, 
				  void *data, u32 data_len)

{

	struct iwl_fw_ini_monitor_dump *mon_dump = (void *)data;

	struct iwl_fw_ini_region_tlv *reg = (void *)reg_data->reg_tlv->data;

	u32 alloc_id = le32_to_cpu(reg->internal_buffer.alloc_id);



	return iwl_dump_ini_mon_fill_header(fwrt, reg_data, mon_dump,

	return iwl_dump_ini_mon_fill_header(fwrt, alloc_id, mon_dump,

					    &fwrt->trans->cfg->mon_smem_regs);

}
@@ -1725,7 +1725,10 @@ iwl_dump_ini_mon_dbgi_fill_header(struct iwl_fw_runtime *fwrt, 
{

	struct iwl_fw_ini_monitor_dump *mon_dump = (void *)data;



	return iwl_dump_ini_mon_fill_header(fwrt, reg_data, mon_dump,

	return iwl_dump_ini_mon_fill_header(fwrt,

					    /* no offset calculation later */

					    IWL_FW_INI_ALLOCATION_ID_DBGC1,

					    mon_dump,

					    &fwrt->trans->cfg->mon_dbgi_regs);

}