Commit d3a3340b authored by Allison Henderson's avatar Allison Henderson Committed by Darrick J. Wong
Browse files

xfs: Initialize error in xfs_attr_remove_iter 



A recent bug report generated a warning that a code path in
xfs_attr_remove_iter could potentially return error uninitialized in the
case of XFS_DAS_RM_SHRINK state.  Fix this by initializing error.

Signed-off-by: default avatarAllison Henderson <allison.henderson@oracle.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarBrian Foster <bfoster@redhat.com>
Reviewed-by: default avatarBill O'Donnell <bodonnel@redhat.com>
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
parent a8f3522c

fs/xfs/libxfs/xfs_attr.c

+1 −1
Original line number Diff line number Diff line
@@ -1375,7 +1375,7 @@ xfs_attr_remove_iter( 
{

	struct xfs_da_args		*args = dac->da_args;

	struct xfs_da_state		*state = dac->da_state;

	int				retval, error;

	int				retval, error = 0;

	struct xfs_inode		*dp = args->dp;



	trace_xfs_attr_node_removename(args);