Commit d39ec8f3 authored by Neeraj Upadhyay's avatar Neeraj Upadhyay Committed by Paul E. McKenney
Browse files

rcu-tasks: Correct comparisons for CPU numbers in show_stalled_task_trace 



Valid CPU numbers can be zero or greater, but the checks for
->trc_ipi_to_cpu and tick_nohz_full_cpu()'s argument are for strictly
greater than.  This commit therefore corrects the check for no_hz_full
cpu in show_stalled_task_trace() so as to include cpu 0.

Signed-off-by: default avatarNeeraj Upadhyay <neeraju@codeaurora.org>
Signed-off-by: default avatarPaul E. McKenney <paulmck@kernel.org>
parent 89401176

kernel/rcu/tasks.h

+2 −2
Original line number Diff line number Diff line
@@ -1084,9 +1084,9 @@ static void show_stalled_task_trace(struct task_struct *t, bool *firstreport) 
	cpu = task_cpu(t);

	pr_alert("P%d: %c%c%c nesting: %d%c cpu: %d\n",

		 t->pid,

		 ".I"[READ_ONCE(t->trc_ipi_to_cpu) > 0],

		 ".I"[READ_ONCE(t->trc_ipi_to_cpu) >= 0],

		 ".i"[is_idle_task(t)],

		 ".N"[cpu > 0 && tick_nohz_full_cpu(cpu)],

		 ".N"[cpu >= 0 && tick_nohz_full_cpu(cpu)],

		 READ_ONCE(t->trc_reader_nesting),

		 " N"[!!READ_ONCE(t->trc_reader_special.b.need_qs)],

		 cpu);