Commit d39353c7 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Noralf Trønnes
Browse files

drm/ili9225: Avoid spamming logs if probe is deferred 



The GPIO request can fail and probe may be deferred. Thus,
the error message may be printed again and again. Avoid
this by replacing DRM_DEV_ERROR() by dev_err_probe().

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarNoralf Trønnes <noralf@tronnes.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210421163157.50949-6-andriy.shevchenko@linux.intel.com
parent 31c7729d

drivers/gpu/drm/tiny/ili9225.c

+4 −8
Original line number Diff line number Diff line
@@ -379,16 +379,12 @@ static int ili9225_probe(struct spi_device *spi) 
	drm = &dbidev->drm;



	dbi->reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);

	if (IS_ERR(dbi->reset)) {

		DRM_DEV_ERROR(dev, "Failed to get gpio 'reset'\n");

		return PTR_ERR(dbi->reset);

	}

	if (IS_ERR(dbi->reset))

		return dev_err_probe(dev, PTR_ERR(dbi->reset), "Failed to get GPIO 'reset'\n");



	rs = devm_gpiod_get(dev, "rs", GPIOD_OUT_LOW);

	if (IS_ERR(rs)) {

		DRM_DEV_ERROR(dev, "Failed to get gpio 'rs'\n");

		return PTR_ERR(rs);

	}

	if (IS_ERR(rs))

		return dev_err_probe(dev, PTR_ERR(rs), "Failed to get GPIO 'rs'\n");



	device_property_read_u32(dev, "rotation", &rotation);