Commit d3715889 authored Jul 20, 2021 by Takashi Iwai

ALSA: pcm: Fix mmap without buffer preallocation

The recent rewrite of the memory allocation helpers also changed the
page extraction to a common helper, snd_sgbuf_get_page().  But this
assumes implicitly that the buffer was allocated via the standard
helper (usually via preallocation), and didn't consider the case of
the manual buffer handling.

This patch fixes it and also covers the manual buffer management.

Fixes: 37af81c5 ("ALSA: core: Abstract memory alloc helpers")
Link: https://lore.kernel.org/r/20210720092732.12412-1-tiwai@suse.de


Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent c4824ae7

sound/core/pcm_native.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -3675,6 +3675,8 @@ static vm_fault_t snd_pcm_mmap_data_fault(struct vm_fault *vmf)
		return VM_FAULT_SIGBUS;
		if (substream->ops->page)
		page = substream->ops->page(substream, offset);
		else if (!snd_pcm_get_dma_buf(substream))
		page = virt_to_page(runtime->dma_area + offset);
		else
		page = snd_sgbuf_get_page(snd_pcm_get_dma_buf(substream), offset);
		if (!page)