Commit d356dbe2 authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller
Browse files

net: pcs: xpcs: Fix a less than zero u16 comparison error 



Currently the check for the u16 variable val being less than zero is
always false because val is unsigned. Fix this by using the int
variable for the assignment and less than zero check.

Addresses-Coverity: ("Unsigned compared against 0")
Fixes: f7380bba ("net: pcs: xpcs: add support for NXP SJA1110")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0c337952

drivers/net/pcs/pcs-xpcs-nxp.c

+6 −6
Original line number Diff line number Diff line
@@ -152,11 +152,11 @@ static int nxp_sja1110_pma_config(struct dw_xpcs *xpcs, 
	/* Enable TX and RX PLLs and circuits.

	 * Release reset of PMA to enable data flow to/from PCS.

	 */

	val = xpcs_read(xpcs, MDIO_MMD_VEND2, SJA1110_POWERDOWN_ENABLE);

	if (val < 0)

		return val;

	ret = xpcs_read(xpcs, MDIO_MMD_VEND2, SJA1110_POWERDOWN_ENABLE);

	if (ret < 0)

		return ret;



	val &= ~(SJA1110_TXPLL_PD | SJA1110_TXPD | SJA1110_RXCH_PD |

	val = ret & ~(SJA1110_TXPLL_PD | SJA1110_TXPD | SJA1110_RXCH_PD |

		      SJA1110_RXBIAS_PD | SJA1110_RESET_SER_EN |

		      SJA1110_RESET_SER | SJA1110_RESET_DES);

	val |= SJA1110_RXPKDETEN | SJA1110_RCVEN;