Commit d351c90c authored by Subbaraya Sundeep's avatar Subbaraya Sundeep Committed by Paolo Abeni
Browse files

octeontx2-pf: Fix UDP/TCP src and dst port tc filters 



Check the mask for non-zero value before installing tc filters
for L4 source and destination ports. Otherwise installing a
filter for source port installs destination port too and
vice-versa.

Fixes: 1d4d9e42 ("octeontx2-pf: Add tc flower hardware offload on ingress traffic")
Signed-off-by: default avatarSubbaraya Sundeep <sbhatta@marvell.com>
Signed-off-by: default avatarSunil Goutham <sgoutham@marvell.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 5ec9c514

drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c

+18 −12
Original line number Diff line number Diff line
@@ -648,15 +648,20 @@ static int otx2_tc_prepare_flow(struct otx2_nic *nic, struct otx2_tc_flow *node, 


		flow_spec->dport = match.key->dst;

		flow_mask->dport = match.mask->dst;



		if (flow_mask->dport) {

			if (ip_proto == IPPROTO_UDP)

				req->features |= BIT_ULL(NPC_DPORT_UDP);

			else if (ip_proto == IPPROTO_TCP)

				req->features |= BIT_ULL(NPC_DPORT_TCP);

			else if (ip_proto == IPPROTO_SCTP)

				req->features |= BIT_ULL(NPC_DPORT_SCTP);

		}



		flow_spec->sport = match.key->src;

		flow_mask->sport = match.mask->src;



		if (flow_mask->sport) {

			if (ip_proto == IPPROTO_UDP)

				req->features |= BIT_ULL(NPC_SPORT_UDP);

			else if (ip_proto == IPPROTO_TCP)
@@ -664,6 +669,7 @@ static int otx2_tc_prepare_flow(struct otx2_nic *nic, struct otx2_tc_flow *node, 
			else if (ip_proto == IPPROTO_SCTP)

				req->features |= BIT_ULL(NPC_SPORT_SCTP);

		}

	}



	return otx2_tc_parse_actions(nic, &rule->action, req, f, node);

}