Commit d33dae51 authored Dec 13, 2021 by Russell King (Oracle) Committed by David S. Miller Dec 13, 2021

net: phy: add a note about refcounting



Recently, a patch has been submitted to "fix" the refcounting for a DT
node in of_mdiobus_link_mdiodev(). This is not a leaked refcount. The
refcount is passed to the new device.

Sadly, coccicheck identifies this location as a leaked refcount, which
means we're likely to keep getting patches to "fix" this. However,
fixing this will cause breakage. Add a comment to state that the lack
of of_node_put() here is intentional.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent be565ec7

drivers/net/phy/mdio_bus.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -460,6 +460,9 @@ static void of_mdiobus_link_mdiodev(struct mii_bus *bus,

		if (addr == mdiodev->addr) {
		device_set_node(dev, of_fwnode_handle(child));
		/* The refcount on "child" is passed to the mdio
		* device. Do _not_ use of_node_put(child) here.
		*/
		return;
		}
		}