Commit d325c34d authored by Gencen Gan's avatar Gencen Gan Committed by David S. Miller
Browse files

net: amd: Fix link leak when verifying config failed 



After failing to verify configuration, it returns directly without
releasing link, which may cause memory leak.

Paolo Abeni thinks that the whole code of this driver is quite
"suboptimal" and looks unmainatained since at least ~15y, so he
suggests that we could simply remove the whole driver, please
take it into consideration.

Simon Horman suggests that the fix label should be set to
"Linux-2.6.12-rc2" considering that the problem has existed
since the driver was introduced and the commit above doesn't
seem to exist in net/net-next.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarGan Gecen <gangecen@hust.edu.cn>
Reviewed-by: default avatarDongliang Mu <dzm91@hust.edu.cn>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d913d32c

drivers/net/ethernet/amd/nmclan_cs.c

+1 −1
Original line number Diff line number Diff line
@@ -651,7 +651,7 @@ static int nmclan_config(struct pcmcia_device *link) 
    } else {

      pr_notice("mace id not found: %x %x should be 0x40 0x?9\n",

		sig[0], sig[1]);

      return -ENODEV;

      goto failed;

    }

  }