Commit d321ff58 authored by Chuck Lever's avatar Chuck Lever Committed by J. Bruce Fields
Browse files

SUNRPC: Fix general protection fault in trace_rpc_xdr_overflow() 



The TP_fast_assign() section is careful enough not to dereference
xdr->rqst if it's NULL. The TP_STRUCT__entry section is not.

Fixes: 5582863f ("SUNRPC: Add XDR overflow trace event")
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent 1905cac9

include/trace/events/sunrpc.h

+4 −4
Original line number Diff line number Diff line
@@ -655,10 +655,10 @@ TRACE_EVENT(rpc_xdr_overflow, 
		__field(size_t, tail_len)

		__field(unsigned int, page_len)

		__field(unsigned int, len)

		__string(progname,

			 xdr->rqst->rq_task->tk_client->cl_program->name)

		__string(procedure,

			 xdr->rqst->rq_task->tk_msg.rpc_proc->p_name)

		__string(progname, xdr->rqst ?

			 xdr->rqst->rq_task->tk_client->cl_program->name : "unknown")

		__string(procedure, xdr->rqst ?

			 xdr->rqst->rq_task->tk_msg.rpc_proc->p_name : "unknown")

	),



	TP_fast_assign(