Commit d310b14a authored by Linus Walleij's avatar Linus Walleij Committed by David S. Miller
Browse files

net: dsa: rtl8366: Drop and depromote pointless prints 



We don't need a message for every VLAN association, dbg
is fine. The message about adding the DSA or CPU
port to a VLAN is directly misleading, this is perfectly
fine.

Cc: Vladimir Oltean <olteanv@gmail.com>
Cc: Mauri Sandberg <sandberg@mailfence.com>
Cc: DENG Qingfang <dqfext@gmail.com>
Reviewed-by: default avatarAlvin Šipraga <alsi@bang-olufsen.dk>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d8251b9d

drivers/net/dsa/rtl8366.c

+4 −7
Original line number Diff line number Diff line
@@ -318,13 +318,10 @@ int rtl8366_vlan_add(struct dsa_switch *ds, int port, 
		return ret;

	}



	dev_info(smi->dev, "add VLAN %d on port %d, %s, %s\n",

	dev_dbg(smi->dev, "add VLAN %d on port %d, %s, %s\n",

		vlan->vid, port, untagged ? "untagged" : "tagged",

		pvid ? "PVID" : "no PVID");



	if (dsa_is_dsa_port(ds, port) || dsa_is_cpu_port(ds, port))

		dev_err(smi->dev, "port is DSA or CPU port\n");



	member |= BIT(port);



	if (untagged)
@@ -356,7 +353,7 @@ int rtl8366_vlan_del(struct dsa_switch *ds, int port, 
	struct realtek_smi *smi = ds->priv;

	int ret, i;



	dev_info(smi->dev, "del VLAN %04x on port %d\n", vlan->vid, port);

	dev_dbg(smi->dev, "del VLAN %d on port %d\n", vlan->vid, port);



	for (i = 0; i < smi->num_vlan_mc; i++) {

		struct rtl8366_vlan_mc vlanmc;