Commit d2e85432 authored by Yang Yingliang's avatar Yang Yingliang Committed by Andrew Morton
Browse files

fail_function: fix wrong use of fei_attr_remove() 

If register_kprobe() fails, the new attr is not added to the list yet, so
it should call fei_attr_free() intstead.

Link: https://lkml.kernel.org/r/20220826073337.2085798-3-yangyingliang@huawei.com


Fixes: 4b1a29a7 ("error-injection: Support fault injection framework")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent cef9f5f8

kernel/fail_function.c

+1 −1
Original line number Diff line number Diff line
@@ -295,7 +295,7 @@ static ssize_t fei_write(struct file *file, const char __user *buffer, 


	ret = register_kprobe(&attr->kp);

	if (ret) {

		fei_attr_remove(attr);

		fei_attr_free(attr);

		goto out;

	}

	fei_debugfs_add_attr(attr);